Introduce JEP for External Fingerprint Storage #289
Conversation
jep/0000/README.adoc
Outdated
|
|
||
| When a plugin is configured and enabled, the fingerprints are transferred from the local storage to the external storage. | ||
|
|
||
| This by followed by clearing the local database of fingerprints from Jenkins HOME ONLY if the writes are successful. |
jep/0000/README.adoc
Outdated
|
|
||
| We do not propose to revamp the `FingerprintCleanupThread` to use the above logic at the moment. | ||
|
|
||
| ==== External to Local Migration (Nice 2 Have) |
There was a problem hiding this comment.
Change "nice 2 have"s to "out of scope for MVP" ... or at the very least, s/2/to/ ;)
There was a problem hiding this comment.
I'd probably actually move these sections to the bottom so they don't distract from the important stuff.
There was a problem hiding this comment.
@afalko thanks! Incorporated "out of scope for MVP" :)
I have these at the end of the Design Decisions section
|
I will go ahead and merge it
…On Fri, Jun 12, 2020, 17:07 Andrey Falko ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#289 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAW4RIEQTKMLYRMWKDBSIWDRWJAD7ANCNFSM4N2ULHCA>
.
|
There was a problem hiding this comment.
Structure of JEP looks good to me and writing is clear. The (out of scope for MVP) sections could perhaps be moved to Reasoning (i.e., why they are out of scope), but I think it is also OK under Specification as you are just noting in which phase something might be implemented.
Co-authored-by: Jesse Glick <[email protected]>
|
JEP-225 ID is locked by #266. It does not really follow the JEP process, but I do not want to provoke additional merge conflicts. We are not required to do sequential numbering. I will merge one as JEP-226. |
| @@ -1,4 +1,4 @@ | |||
| = JEP-0000: External Fingerprint Storage | |||
| = JEP-226: External Fingerprint Storage | |||
There was a problem hiding this comment.
@oleg-nenashev will you update https://www.jenkins.io/sigs/cloud-native/pluggable-storage/ to match?
There was a problem hiding this comment.
Thanks for pointing it out @jglick, Ill submit a PR to update it
There was a problem hiding this comment.
Somebody will do it, if course.
There was a problem hiding this comment.
CC @oleg-nenashev @afalko @mikecirioli